| Date | Thu, 6 Jul 2023 12:55:18 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v2 33/92] cramfs: convert to ctime accessor functions |
| |
On Wed 05-07-23 15:00:58, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Acked-by: Nicolas Pitre <nico@fluxnic.net> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/cramfs/inode.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c > index 27c6597aa1be..e755b2223936 100644 > --- a/fs/cramfs/inode.c > +++ b/fs/cramfs/inode.c > @@ -133,7 +133,8 @@ static struct inode *get_cramfs_inode(struct super_block *sb, > } > > /* Struct copy intentional */ > - inode->i_mtime = inode->i_atime = inode->i_ctime = zerotime; > + inode->i_mtime = inode->i_atime = inode_set_ctime_to_ts(inode, > + zerotime); > /* inode->i_nlink is left 1 - arguably wrong for directories, > but it's the best we can do without reading the directory > contents. 1 yields the right result in GNU find, even > -- > 2.41.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
|