| Date | Thu, 6 Jul 2023 13:19:19 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v2 45/92] freevxfs: convert to ctime accessor functions |
| |
On Wed 05-07-23 15:01:10, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/freevxfs/vxfs_inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/freevxfs/vxfs_inode.c b/fs/freevxfs/vxfs_inode.c > index ceb6a12649ba..ac5d43b164b5 100644 > --- a/fs/freevxfs/vxfs_inode.c > +++ b/fs/freevxfs/vxfs_inode.c > @@ -110,10 +110,9 @@ static inline void dip2vip_cpy(struct vxfs_sb_info *sbi, > inode->i_size = vip->vii_size; > > inode->i_atime.tv_sec = vip->vii_atime; > - inode->i_ctime.tv_sec = vip->vii_ctime; > + inode_set_ctime(inode, vip->vii_ctime, 0); > inode->i_mtime.tv_sec = vip->vii_mtime; > inode->i_atime.tv_nsec = 0; > - inode->i_ctime.tv_nsec = 0; > inode->i_mtime.tv_nsec = 0; > > inode->i_blocks = vip->vii_blocks; > -- > 2.41.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
|