lkml.org 
[lkml]   [2023]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 53/92] isofs: convert to ctime accessor functions
    On Wed 05-07-23 15:01:18, Jeff Layton wrote:
    > In later patches, we're going to change how the inode's ctime field is
    > used. Switch to using accessor functions instead of raw accesses of
    > inode->i_ctime.
    >
    > Signed-off-by: Jeff Layton <jlayton@kernel.org>
    > ---
    > fs/isofs/inode.c | 8 ++++----
    > fs/isofs/rock.c | 16 +++++++---------
    > 2 files changed, 11 insertions(+), 13 deletions(-)
    >
    > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
    > index df9d70588b60..98a78200cff1 100644
    > --- a/fs/isofs/inode.c
    > +++ b/fs/isofs/inode.c
    > @@ -1424,11 +1424,11 @@ static int isofs_read_inode(struct inode *inode, int relocated)
    > #endif
    >
    > inode->i_mtime.tv_sec =
    > - inode->i_atime.tv_sec =
    > - inode->i_ctime.tv_sec = iso_date(de->date, high_sierra);
    > + inode->i_atime.tv_sec = inode_set_ctime(inode,
    > + iso_date(de->date, high_sierra),
    > + 0).tv_sec;
    > inode->i_mtime.tv_nsec =
    > - inode->i_atime.tv_nsec =
    > - inode->i_ctime.tv_nsec = 0;
    > + inode->i_atime.tv_nsec = 0;

    This would be IMHO more readable as:

    inode->i_mtime = inode->i_atime =
    inode_set_ctime(inode, iso_date(de->date, high_sierra), 0);


    Otherwise the patch looks good.

    Honza
    --
    Jan Kara <jack@suse.com>
    SUSE Labs, CR

    \
     
     \ /
      Last update: 2023-07-06 14:41    [W:4.134 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site