lkml.org 
[lkml]   [2023]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 05/20] ARM: dts: imx6qdl: use enet_clk_ref instead of enet_out for the FEC node
From
Hi Oleksij,

On 1/13/2023 10:27 PM, Oleksij Rempel wrote:
> Old imx6q machine code makes RGMII/RMII clock direction decision based on
> configuration of "ptp" clock. "enet_out" is not used and make no real
> sense, since we can't configure it as output or use it as clock
> provider.
>
> Instead of "enet_out" use "enet_clk_ref" which is actual selector to
> choose between internal and external clock source:
>
> FEC MAC <---------- enet_clk_ref <--------- SoC PLL
> \
> ^------<-> refclock PAD (bi directional)
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index ff1e0173b39b..71522263031a 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -1050,8 +1050,8 @@ fec: ethernet@2188000 {
> clocks = <&clks IMX6QDL_CLK_ENET>,
> <&clks IMX6QDL_CLK_ENET>,
> <&clks IMX6QDL_CLK_ENET_REF>,
> - <&clks IMX6QDL_CLK_ENET_REF>;
> - clock-names = "ipg", "ahb", "ptp", "enet_out";
> + <&clks IMX6QDL_CLK_ENET_REF_SEL>;
> + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";


Please also update fec binding, otherwise there will be dtbs check error.

Thanks,
Peng.

> fsl,stop-mode = <&gpr 0x34 27>;
> status = "disabled";
> };

\
 
 \ /
  Last update: 2023-03-26 23:42    [W:0.237 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site