lkml.org 
[lkml]   [2023]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 08/20] ARM: dts: imx6dl-plybas: configure ethernet reference clock parent
Hi Oleksij,

On Fri, Jan 13, 2023 at 11:27 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> Configure Ethernet reference clock parent in an obvious way instead of
> using cryptic ptp way.

Could you please improve the commit log?

The "obvious way" is not obvious for people that don't have the board
schematics.

I like better the way you described the 20/20 patch:

"On this board the PHY is the ref clock provider. So, configure ethernet
reference clock as input."

Please use this format globally in the series, as it becomes clear who
is providing the ref clock.

Thanks

\
 
 \ /
  Last update: 2023-03-26 23:41    [W:0.172 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site