lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 00/34] Printbufs - new data structure for building strings
On Sun, 19 Jun 2022 20:41:59 -0400
Kent Overstreet <kent.overstreet@gmail.com> wrote:

> Core idea: Wouldn't it be nice if we had a common data structure and calling
> convention for outputting strings?

Because seq_buf gives us this already, the cover letter really just needs
to state exactly what the benefit is to replace seq_buf with printbuf (and
why seq_buf can not be simply extended to do some extra features).

I just applied your series and ran the tracing selftests and several of
them failed.

# cd tools/testing/selftests/ftrace/
# ./ftracetest

This means that this is not a simple replacement and that there's going to
be regressions with this change. The question is, is the added benefits of
doing the change greater than the fallout of the regressions?

-- Steve

\
 
 \ /
  Last update: 2022-07-20 01:16    [W:0.274 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site