[lkml]   [2022]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 00/34] Printbufs - new data structure for building strings
On 20/06/2022 02.41, Kent Overstreet wrote:

> Rasmus pointed out that -fno-strict-aliasing is going to cause gcc to generate
> nasty code, and indeed it unfortunately does but according to worst case
> scenario microbenchmarks it's not a problem for actual performance.

Well, that's not how I interpreted those numbers, but, except if they
showed an improvement, how much is acceptable is of course always a
matter of judgment.

However, what's really annoying and somewhat dishonest is that you're
not including those numbers, nor the methodology, in either the cover
letter or commit itself.


 \ /
  Last update: 2022-06-21 08:12    [W:0.508 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site