Messages in this thread | | | Date | Fri, 1 Jul 2022 12:02:51 +0530 | Subject | Re: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf | From | Shivaprasad G Bhat <> |
| |
On 6/25/22 05:12, Santosh Sivaraj wrote: > I don't have setup to test this now. Adding Shiva and Vaibhav who could > probably help. Thanks, Santosh On Sat, 25 Jun, 2022, 1:03 am Dan > Williams, <dan.j.williams@intel.com> wrote: [ add Santosh ] Kent > Overstreet wrote: > ZjQcmQRYFpfptBannerStart > This Message Is From an External Sender > This message came from outside your organization. > ZjQcmQRYFpfptBannerEnd > I don't have setup to test this now. Adding Shiva and Vaibhav who could > probably help. > > Thanks, > Santosh > > On Sat, 25 Jun, 2022, 1:03 am Dan Williams, <dan.j.williams@intel.com > <mailto:dan.j.williams@intel.com>> wrote: > > [ add Santosh ] > > Kent Overstreet wrote: > > This converts from seq_buf to printbuf. Here we're using printbuf > with > > an external buffer, meaning it's a direct conversion. > > > > Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com > <mailto:kent.overstreet@gmail.com>> > > Cc: Dan Williams <dan.j.williams@intel.com > <mailto:dan.j.williams@intel.com>> > > Cc: Dave Hansen <dave.hansen@linux.intel.com > <mailto:dave.hansen@linux.intel.com>> > > Cc: nvdimm@lists.linux.dev <mailto:nvdimm@lists.linux.dev> > > Acked-by: Dan Williams <dan.j.williams@intel.com > <mailto:dan.j.williams@intel.com>> >
The ndtest build requires [1] as the build is currently broken from nd_namespace_blk/blk_region infrastructure removal.
Dan, Could you review [1] and see if it can be included as well ?
With [1], the this patch is tested, and works fine.
Tested-By: Shivaprasad G Bhat <sbhat@linux.ibm.com>
References: [1] https://patchwork.kernel.org/project/linux-nvdimm/patch/165025395730.2821159.14794984437851867426.stgit@lep8c.aus.stglabs.ibm.com/
> This probably also wants a Tested-by from Santosh, but it looks ok > to me. >
| |