lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 05/12] md/raid5: Factor out helper from raid5_make_request() loop
> +	if (unlikely(conf->reshape_progress != MaxSector)) {
> + /* spinlock is needed as reshape_progress may be

Normal kernel style is to stat with a

/*

line and to captalize the first word. (also applies for a few other
comments).

> + if (must_retry) {
> + raid5_release_stripe(sh);
> + return STRIPE_SCHEDULE_AND_RETRY;

The raid5_release_stripe cleanup is duplicated a few times. I think
using goto based unwinding would be hepful in this function.

\
 
 \ /
  Last update: 2022-04-21 08:16    [W:0.258 / U:1.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site