| Date | Wed, 20 Apr 2022 23:14:31 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 05/12] md/raid5: Factor out helper from raid5_make_request() loop |
| |
> + if (unlikely(conf->reshape_progress != MaxSector)) { > + /* spinlock is needed as reshape_progress may be
Normal kernel style is to stat with a
/*
line and to captalize the first word. (also applies for a few other comments).
> + if (must_retry) { > + raid5_release_stripe(sh); > + return STRIPE_SCHEDULE_AND_RETRY;
The raid5_release_stripe cleanup is duplicated a few times. I think using goto based unwinding would be hepful in this function.
|