lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/12] md/raid5: Move common stripe count increment code into __find_stripe()
    On Wed, Apr 20, 2022 at 01:54:17PM -0600, Logan Gunthorpe wrote:
    > Both uses of find_stripe() require a fairly complicated dance to
    > increment the reference count. Move this into a common find_get_stripe()
    > helper.
    >
    > No functional changes intended.

    The subject is wrong now.

    > static struct stripe_head *__find_stripe(struct r5conf *conf, sector_t sector,
    > - short generation)
    > + short generation, int hash)
    > {
    > struct stripe_head *sh;
    >
    > @@ -624,6 +624,49 @@ static struct stripe_head *__find_stripe(struct r5conf *conf, sector_t sector,
    > return NULL;
    > }

    And the new hash argument here is not needed.

    Otherwise looks good:

    Reviewed-by: Christoph Hellwig <hch@lst.de>

    \
     
     \ /
      Last update: 2022-04-21 08:11    [W:2.662 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site