Messages in this thread | | | Subject | Re: [PATCH v2 12/12] md/raid5: Pivot raid5_make_request() | From | Guoqing Jiang <> | Date | Thu, 28 Apr 2022 09:32:04 +0800 |
| |
On 4/28/22 12:18 AM, Logan Gunthorpe wrote: >>> diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h >>> index 638d29863503..e73b58844f83 100644 >>> --- a/drivers/md/raid5.h >>> +++ b/drivers/md/raid5.h >>> @@ -308,6 +308,7 @@ enum r5dev_flags { >>> R5_Wantwrite, >>> R5_Overlap, /* There is a pending overlapping request >>> * on this block */ >>> + R5_BioReady, /* The current bio can be added to this disk */ >> This doesn't seem right to me, since the comment describes bio status >> while others >> are probably for r5dev. > I'm not sure I understand the objection. If you have a better option > please let me know.
As said, the flag is for r5dev not for bio, please don't make people confuse about it.
My personal suggestion would be change it to R5_Ready_For_BIO or some thing else, then update the comment accordingly.
> I'm still working on this patch. Caught a couple more rare bugs that I'm > working to fix. The next version should also hopefully be clearer.
Thanks, Guoqing
| |