Messages in this thread | | | Date | Wed, 27 Apr 2022 10:07:48 -0600 | From | Logan Gunthorpe <> | Subject | Re: [PATCH v2 01/12] md/raid5: Factor out ahead_of_reshape() function |
| |
On 2022-04-26 19:28, Guoqing Jiang wrote: >> +static bool ahead_of_reshape(struct mddev *mddev, sector_t sector, >> + sector_t reshape_sector) >> +{ >> + if (mddev->reshape_backwards) >> + return sector < reshape_sector; >> + else >> + return sector >= reshape_sector; >> +} > > I think it can be an inline function.
Marking static functions in C files as inline is not recommended. GCC will inline it, if it is appropriate.
https://yarchive.net/comp/linux/inline.html https://www.kernel.org/doc/local/inline.html
Logan
| |