| Date | Wed, 20 Apr 2022 23:07:48 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 01/12] md/raid5: Factor out ahead_of_reshape() function |
| |
On Wed, Apr 20, 2022 at 01:54:14PM -0600, Logan Gunthorpe wrote: > +static bool ahead_of_reshape(struct mddev *mddev, sector_t sector, > + sector_t reshape_sector) > +{ > + if (mddev->reshape_backwards) > + return sector < reshape_sector; > + else > + return sector >= reshape_sector; > +}
No real eed for the else here. Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
|