Messages in this thread | | | From | Sam Protsenko <> | Date | Fri, 25 Nov 2022 08:38:11 -0600 | Subject | Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 |
| |
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even > though Linux currently does not enable them and relies on bootloader. >
Not sure if this description is correct. Of course, there is no driver for "samsung,exynos850-sysreg" compatible at the moment, so the next compatible from the list ("syscon") is used for Exynos850. And "syscon" driver (drivers/mfd/syscon.c) actually does control the clocks. I remember adding "clocks" property to Exynos850 dts to fix actual problem. Also, the "clocks" property is not described in Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check if it's ok or it's just missing.
Other than that comment:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Sriranjani P <sriranjani.p@samsung.com> > Cc: Chanho Park <chanho61.park@samsung.com> > Cc: Sam Protsenko <semen.protsenko@linaro.org> > --- > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index 42357466005e..27cea934a286 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -36,10 +36,25 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > required: > - compatible > - reg > > +allOf: > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynos850-sysreg > + then: > + properties: > + clocks: false > + > additionalProperties: false > > examples: > -- > 2.34.1 >
| |