Messages in this thread | | | From | Sam Protsenko <> | Date | Fri, 25 Nov 2022 09:01:15 -0600 | Subject | Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 |
| |
On Fri, 25 Nov 2022 at 08:49, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 25/11/2022 15:38, Sam Protsenko wrote: > > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even > >> though Linux currently does not enable them and relies on bootloader. > >> > > > > Not sure if this description is correct. Of course, there is no driver > > for "samsung,exynos850-sysreg" compatible at the moment, so the next > > compatible from the list ("syscon") is used for Exynos850. And > > "syscon" driver (drivers/mfd/syscon.c) actually does control the > > clocks. I remember adding "clocks" property to Exynos850 dts to fix > > actual problem. Also, the "clocks" property is not described in > > Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check > > if it's ok or it's just missing. > > > > Other than that comment: > > > > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > > > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Ah, then commit msg is not good. I'll update it and maybe the clocks > should be required for Exynos850? >
Yeah, looks like all Exynos850 sysreg blocks have dedicated clock. Please make it required. And thanks for working on that! :)
> Best regards, > Krzysztof >
| |