lkml.org 
[lkml]   [2022]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---

Hi Krzysztof,

Just curious: what is the rationale for adding those more specific
sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
pretty much the same register layout.

Other than that:

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
>

\
 
 \ /
  Last update: 2022-11-25 15:23    [W:0.489 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site