lkml.org 
[lkml]   [2022]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
    From
    On 25/11/2022 15:38, Sam Protsenko wrote:
    > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
    > <krzysztof.kozlowski@linaro.org> wrote:
    >>
    >> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
    >> though Linux currently does not enable them and relies on bootloader.
    >>
    >
    > Not sure if this description is correct. Of course, there is no driver
    > for "samsung,exynos850-sysreg" compatible at the moment, so the next
    > compatible from the list ("syscon") is used for Exynos850. And
    > "syscon" driver (drivers/mfd/syscon.c) actually does control the
    > clocks. I remember adding "clocks" property to Exynos850 dts to fix
    > actual problem. Also, the "clocks" property is not described in
    > Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
    > if it's ok or it's just missing.
    >
    > Other than that comment:
    >
    > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
    >
    >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    Ah, then commit msg is not good. I'll update it and maybe the clocks
    should be required for Exynos850?

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-11-25 15:49    [W:5.632 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site