lkml.org 
[lkml]   [2022]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 33/35] brcmfmac: common: Add support for downloading TxCap blobs
On 1/4/2022 8:26 AM, Hector Martin wrote:
> The TxCap blobs are additional data blobs used on Apple devices, and
> are uploaded analogously to CLM blobs. Add core support for doing this.

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> .../broadcom/brcm80211/brcmfmac/bus.h | 1 +
> .../broadcom/brcm80211/brcmfmac/common.c | 97 +++++++++++++------
> 2 files changed, 71 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h
> index b13af8f631f3..f4bd98da9761 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h
> @@ -39,6 +39,7 @@ enum brcmf_bus_protocol_type {
> /* Firmware blobs that may be available */
> enum brcmf_blob_type {
> BRCMF_BLOB_CLM,
> + BRCMF_BLOB_TXCAP,
> };
>
> struct brcmf_mp_device;
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
> index c84c48e49fde..d65308c3f070 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c

[...]

> @@ -165,20 +157,64 @@ static int brcmf_c_process_clm_blob(struct brcmf_if *ifp)
> } while ((datalen > 0) && (err == 0));
>

[...]

> +static int brcmf_c_process_txcap_blob(struct brcmf_if *ifp)
> +{
> + struct brcmf_pub *drvr = ifp->drvr;
> + struct brcmf_bus *bus = drvr->bus_if;
> + const struct firmware *fw = NULL;
> + s32 err;
> +
> + brcmf_dbg(TRACE, "Enter\n");
> +
> + err = brcmf_bus_get_blob(bus, &fw, BRCMF_BLOB_TXCAP);
> + if (err || !fw) {
> + brcmf_info("no txcap_blob available (err=%d)\n", err);
> + return 0;
> + }
> +
> + brcmf_info("TxCap blob found, loading\n");
> + err = brcmf_c_download_blob(ifp, fw->data, fw->size,
> + "txcapload", "txcapload_status");

Although unlikely that we end up here with a firmware that does not
support this command it is not impossible. Should we handle that here or
introduce a feature flag for txcap loading?

> + release_firmware(fw);
> return err;
> }
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2022-01-21 08:38    [W:1.784 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site