lkml.org 
[lkml]   [2022]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 02/35] brcmfmac: pcie: Declare missing firmware files in pcie.c
From
On 2022/01/06 18:56, Arend van Spriel wrote:
> On 1/4/2022 8:26 AM, Hector Martin wrote:
>> Move one of the declarations from sdio.c to pcie.c, since it makes no
>> sense in the former (SDIO support is optional), and add missing ones.
>
> Actually, any bus is optional so each bus should indeed declare the
> applicable firmware names/patterns.

Of course; I didn't mean *only* SDIO support is optional :)

>> +/* firmware config files */
>> +MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH "brcmfmac*-pcie.txt");
>
> what is this one for? Those would be covered by the specific
> BRCMF_FW_DEF() macro instances, no?

The BRCMF_FW_DEF() macro only declares the .bin file; BRCMF_FW_CLM_DEF
declares that and the .clm_blob. Neither declare the NVRAM .txt.

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub

\
 
 \ /
  Last update: 2022-01-06 12:11    [W:0.130 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site