| Date | Fri, 21 Jan 2022 08:35:17 +0100 | From | Arend van Spriel <> | Subject | Re: [PATCH v2 24/35] brcmfmac: feature: Add support for setting feats based on WLC version |
| |
On 1/4/2022 8:26 AM, Hector Martin wrote: > The "wlc_ver" iovar returns information on the WLC and EPI versions. > This can be used to determine whether the PMKID_V2 and _V3 features are > supported.
I have my doubts whether this mechanism will be reliable, but we can wait and see whatever hits the fan over time. I stayed away from this because it is not well guarded. Especially when there are 4 entities these days spinning firmware and tinkering on the firmware api without much collaboration.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > .../broadcom/brcm80211/brcmfmac/feature.c | 48 +++++++++++++++++++ > .../broadcom/brcm80211/brcmfmac/feature.h | 4 +- > .../broadcom/brcm80211/brcmfmac/fwil_types.h | 25 ++++++++++ > 3 files changed, 76 insertions(+), 1 deletion(-) [unhandled content-type:application/pkcs7-signature] |