Messages in this thread | | | Date | Wed, 19 Jan 2022 13:36:10 +0100 | From | Arend van Spriel <> | Subject | Re: [PATCH v2 21/35] brcmfmac: chip: Only disable D11 cores; handle an arbitrary number |
| |
On 1/4/2022 8:26 AM, Hector Martin wrote: > At least on BCM4387, the D11 cores are held in reset on cold startup and > firmware expects to release reset itself. Just assert reset here and let > firmware deassert it. Premature deassertion results in the firmware > failing to initialize properly some of the time, with strange AXI bus > errors. > > Also, BCM4387 has 3 cores, up from 2. The logic for handling that is in > brcmf_chip_ai_resetcore(), but since we aren't using that any more, just > handle it here.
Makes sense.
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) [unhandled content-type:application/pkcs7-signature] | |