| Date | Thu, 21 Oct 2021 09:34:58 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 16/20] signal/sparc32: In setup_rt_frame and setup_fram use force_fatal_sig |
| |
On Wed, Oct 20, 2021 at 12:44:02PM -0500, Eric W. Biederman wrote: > Modify the 32bit version of setup_rt_frame and setup_frame to act > similar to the 64bit version of setup_rt_frame and fail with a signal > instead of calling do_exit. > > Replacing do_exit(SIGILL) with force_fatal_signal(SIGILL) ensures that > the process will be terminated cleanly when the stack frame is > invalid, instead of just killing off a single thread and leaving the > process is a weird state. > > Cc: David Miller <davem@davemloft.net> > Cc: sparclinux@vger.kernel.org > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Nicely already had the return path written. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|