lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 01/20] exit/doublefault: Remove apparently bogus comment about rewind_stack_do_exit
    I do not see panic calling rewind_stack_do_exit anywhere, nor can I
    find anywhere in the history where doublefault_shim has called
    rewind_stack_do_exit. So I don't think this comment was ever actually
    correct.

    Cc: Andy Lutomirski <luto@kernel.org>
    Fixes: 7d8d8cfdee9a ("x86/doublefault/32: Rewrite the x86_32 #DF handler and unify with 64-bit")
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    ---
    arch/x86/kernel/doublefault_32.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/arch/x86/kernel/doublefault_32.c b/arch/x86/kernel/doublefault_32.c
    index d1d49e3d536b..3b58d8703094 100644
    --- a/arch/x86/kernel/doublefault_32.c
    +++ b/arch/x86/kernel/doublefault_32.c
    @@ -77,9 +77,6 @@ asmlinkage noinstr void __noreturn doublefault_shim(void)
    * some way to reconstruct CR3. We could make a credible guess based
    * on cpu_tlbstate, but that would be racy and would not account for
    * PTI.
    - *
    - * Instead, don't bother. We can return through
    - * rewind_stack_do_exit() instead.
    */
    panic("cannot return from double fault\n");
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2021-10-20 19:45    [W:4.026 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site