| Date | Thu, 21 Oct 2021 09:17:41 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 11/20] signal/s390: Use force_sigsegv in default_trap_handler |
| |
On Wed, Oct 20, 2021 at 12:43:57PM -0500, Eric W. Biederman wrote: > Reading the history it is unclear why default_trap_handler calls > do_exit. It is not even menthioned in the commit where the change > happened. My best guess is that because it is unknown why the > exception happened it was desired to guarantee the process never > returned to userspace. > > Using do_exit(SIGSEGV) has the problem that it will only terminate one > thread of a process, leaving the process in an undefined state. > > Use force_sigsegv(SIGSEGV) instead which effectively has the same > behavior except that is uses the ordinary signal mechanism and > terminates all threads of a process and is generally well defined. > > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Vasily Gorbik <gor@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: linux-s390@vger.kernel.org > Fixes: ca2ab03237ec ("[PATCH] s390: core changes") > History Tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|