| Date | Sun, 3 May 2015 00:11:30 +0200 | From | Stefan Lippers-Hollmann <> | Subject | Re: [PATCH 4.0 219/220] netfilter: x_tables: fix cgroup matching on non-full sks |
| |
Hi
On 2015-05-02, Greg Kroah-Hartman wrote: > 4.0-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Daniel Borkmann <daniel@iogearbox.net> > > commit afb7718016fcb0370ac29a83b2839c78b76c2960 upstream. > > While originally only being intended for outgoing traffic, commit > a00e76349f35 ("netfilter: x_tables: allow to use cgroup match for > LOCAL_IN nf hooks") enabled xt_cgroups for the NF_INET_LOCAL_IN hook > as well, in order to allow for nfacct accounting. > > Besides being currently limited to early demuxes only, commit > a00e76349f35 forgot to add a check if we deal with full sockets, > i.e. in this case not with time wait sockets. TCP time wait sockets > do not have the same memory layout as full sockets, a lower memory > footprint and consequently also don't have a sk_classid member; > probing for sk_classid member there could potentially lead to a > crash.
This introduces the same build failure into queue-4.0, as previously reported by Thomas Backlund for queue-3.19 in
http://lkml.kernel.org/r/<554545E5.8020606@mageia.org>
/tmp/buildd/linux-aptosid-4.0/net/netfilter/xt_cgroup.c: In function 'cgroup_mt': /tmp/buildd/linux-aptosid-4.0/net/netfilter/xt_cgroup.c:42:2: error: implicit declaration of function 'sk_fullsock' [-Werror=implicit-function-declaration] if (skb->sk == NULL || !sk_fullsock(skb->sk)) ^ cc1: some warnings being treated as errors /tmp/buildd/linux-aptosid-4.0/scripts/Makefile.build:264: recipe for target 'net/netfilter/xt_cgroup.o' failed make[7]: *** [net/netfilter/xt_cgroup.o] Error 1
Regards Stefan Lippers-Hollmann
|