lkml.org 
[lkml]   [2015]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.0 055/220] compal-laptop: Fix leaking hwmon device
    Date
    4.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    commit ad774702f1705c04e5fa492b793d8d477a504fa6 upstream.

    The commit c2be45f09bb0 ("compal-laptop: Use
    devm_hwmon_device_register_with_groups") wanted to change the
    registering of hwmon device to resource-managed version. It mostly did
    it except the main thing - it forgot to use devm-like function so the
    hwmon device leaked after device removal or probe failure.

    Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups")
    Acked-by: Guenter Roeck <linux@roeck-us.net>
    Acked-by: Darren Hart <dvhart@linux.intel.com>
    Signed-off-by: Sebastian Reichel <sre@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/platform/x86/compal-laptop.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/platform/x86/compal-laptop.c
    +++ b/drivers/platform/x86/compal-laptop.c
    @@ -1026,9 +1026,9 @@ static int compal_probe(struct platform_
    if (err)
    return err;

    - hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,
    - "compal", data,
    - compal_hwmon_groups);
    + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev,
    + "compal", data,
    + compal_hwmon_groups);
    if (IS_ERR(hwmon_dev)) {
    err = PTR_ERR(hwmon_dev);
    goto remove;



    \
     
     \ /
      Last update: 2015-05-02 21:21    [W:9.755 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site