| Date | Thu, 13 Mar 2014 16:05:34 +0000 | From | Will Deacon <> | Subject | Re: [PATCH v6 3/7] ftrace: Add arm64 support to recordmcount |
| |
On Thu, Mar 13, 2014 at 02:57:58PM +0000, AKASHI Takahiro wrote: > On 03/13/2014 09:38 PM, Will Deacon wrote: > > On Thu, Mar 13, 2014 at 10:13:46AM +0000, AKASHI Takahiro wrote: > >> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > >> index 91280b8..397b6b8 100755 > >> --- a/scripts/recordmcount.pl > >> +++ b/scripts/recordmcount.pl > >> @@ -279,6 +279,11 @@ if ($arch eq "x86_64") { > >> $mcount_regex = "^\\s*([0-9a-fA-F]+):\\s*R_ARM_(CALL|PC24|THM_CALL)" . > >> "\\s+(__gnu_mcount_nc|mcount)\$"; > >> > >> +} elsif ($arch eq "arm64") { > >> + $alignment = 3; > >> + $section_type = '%progbits'; > >> + $mcount_regex = "^\\s*([0-9a-fA-F]+):\\s*R_AARCH64_CALL26\\s+_mcount\$"; > > > > What about "mcount" (i.e. no underscore)? > > I don't think it works since such regex doesn't match to "CALL26 _mcount".
What I meant was, do you need to match "mcount" as well? However, after speaking to our GCC guys, they say they only support "_mcount" (preferred) and "__mcount" (which GCC itself doesn't emit) so you can leave this regex as-is.
Will
|