lkml.org 
[lkml]   [2014]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 4/7] arm64: Add ftrace support
On Thu, Mar 13, 2014 at 06:27:39PM +0000, Steven Rostedt wrote:
> On Thu, 2014-03-13 at 17:08 +0000, Will Deacon wrote:
>
> > > + /*
> > > + * Note:
> > > + * No protection against faulting at *parent, which may be seen
> > > + * on other archs. It's unlikely on AArch64.
> > > + */
> > > + old = *parent;
> > > + *parent = return_hooker;
> >
> > return_hook? People might take it personally otherwise ;)
>
> No, return_hooker is consistent with all the other archs. Hey, it's a
> rugby position! Note, which I was when I played. ;-)

Hehe, in which case your children will be able to execute that line of
ftrace!

> >
> > > + trace.func = self_addr;
> >
> > in kernel/ftrace/ftrace.c there's an smb_wmb() between setting up
> > tracing_graph_pause and setting the ret_stack with a comment saying:
> >
> > /* Make sure the tasks see the -1 first: */
> >
> > Why don't we have a corresponding read-barrier here?
>
> The corresponding rmb is in kernel/trace/trace_function_graph
> ftrace_push_return_trace().

Okey doke then, I guess we don't really care about tracing_graph_pause
getting out-of-sync with curr_ret_stack.

Will


\
 
 \ /
  Last update: 2014-03-13 20:21    [W:0.398 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site