Messages in this thread Patch in this message | | | From | Brian Norris <> | Subject | [PATCH] checkpatch: enable MAINTAINERS warning only for --strict,--subjective | Date | Tue, 16 Dec 2014 23:35:32 -0800 |
| |
The rule which delivers this warning is very prone to errors:
"added, moved or deleted file(s), does MAINTAINERS need updating?"
so it should not be enabled by default.
The current checkpatch rule doesn't check: 1. whether other patches in the same series update MAINTAINERS 2. whether MAINTAINERS already contains a sufficient entry (e.g., with an appropriate wildcard pattern)
Given that #1 is impossible to fix and #2 is highly subjective (what's "appropriate"? is the subsystem maintainer fine with maintaining a new small driver? or should the driver author be adding himself/herself for a niche driver?), I'd be just as happy to remove this rule entirely.
Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f0bb6d60c07b..7057d1f54947 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2189,7 +2189,7 @@ sub process { } # Check for added, moved or deleted files - if (!$reported_maintainer_file && !$in_commit_log && + if ($check && !$reported_maintainer_file && !$in_commit_log && ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ || $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ || ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ && -- 1.9.1
| |