Messages in this thread | | | From | Kevin Cernekee <> | Date | Wed, 17 Dec 2014 07:53:27 -0800 | Subject | Re: [PATCH] checkpatch: enable MAINTAINERS warning only for --strict,--subjective |
| |
On Wed, Dec 17, 2014 at 1:27 AM, Joe Perches <joe@perches.com> wrote: > On Tue, 2014-12-16 at 23:35 -0800, Brian Norris wrote: >> The rule which delivers this warning is very prone to errors: >> "added, moved or deleted file(s), does MAINTAINERS need updating?" >> so it should not be enabled by default. > > I don't think so. > > It's _far_ more common for people to forget to > update MAINTAINERS so I think it's quite useful > even if it's slightly noisy.
In a recent submission I saw a bunch of these warnings too, even though I had already added MAINTAINERS entries.
If this is just a friendly reminder ("hey, please double-check X before you send") rather than an indication that a suspected problem was detected in the patch, perhaps it would be better if it lived in Documentation/SubmitChecklist?
| |