Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Fix MAINTAINERS search pattern | From | Joe Perches <> | Date | Thu, 18 Dec 2014 19:57:53 -0800 |
| |
On Fri, 2014-12-19 at 02:34 +0000, Chickles, Derek wrote: > > On Thu, 2014-12-18 at 12:12 -0800, Derek Chickles wrote: > > > This fixes the check that was supposed to prevent the MAINTAINERS > > > warning from appearing when you run checkpatch.pl on a patch that > > > includes new files/directories and an updated MAINTAINERS file. > > > > This suggested patch doesn't work. > > > > $realfile isn't set until the file shows up > > in the patch itself. > > > > The current test looks at the changelog > > before the files are modified and is correct. > > > > Thanks, you're right. My mistake was trying to run checkpatch.pl on a diff. > My patch works on diffs while the original code does not. This is by chance > really because MAINTAINERS is early in the patch. Using format-patch on > something that is committed is clearly the correct solution.
Both tests can be used.
Send another patch without deleting the first test and that'd be good to me.
| |