Messages in this thread | | | From | "Chickles, Derek" <> | Subject | RE: [PATCH] checkpatch: Fix MAINTAINERS search pattern | Date | Fri, 19 Dec 2014 02:34:24 +0000 |
| |
> On Thu, 2014-12-18 at 12:12 -0800, Derek Chickles wrote: > > This fixes the check that was supposed to prevent the MAINTAINERS > > warning from appearing when you run checkpatch.pl on a patch that > > includes new files/directories and an updated MAINTAINERS file. > > This suggested patch doesn't work. > > $realfile isn't set until the file shows up > in the patch itself. > > The current test looks at the changelog > before the files are modified and is correct. >
Thanks, you're right. My mistake was trying to run checkpatch.pl on a diff. My patch works on diffs while the original code does not. This is by chance really because MAINTAINERS is early in the patch. Using format-patch on something that is committed is clearly the correct solution.
| |