| Date | Thu, 07 Feb 2013 16:38:02 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH v3 07/23] tty: Strengthen no-subsequent-use guarantee of tty_ldisc_halt() |
| |
On 02/05/2013 09:20 PM, Peter Hurley wrote: > @@ -688,9 +702,9 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc) > * parallel to the change and re-referencing the tty. > */ > > - work = tty_ldisc_halt(tty); > + retval = tty_ldisc_halt(tty, &work, 5 * HZ); > if (o_tty) > - o_work = tty_ldisc_halt(o_tty); > + tty_ldisc_halt(o_tty, &o_work, 0);
Zero in there will cause the other end's work not to be cancelled and TTY_LDISC_HALTED unset if there are two or more readers on the slave, right? So there should be something like: if (timeout) retval = tty_ldisc_wait_idle(tty, timeout); ...
in tty_ldisc_halt.
-- js suse labs
|