lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 16/32] tty: Fix 'deferred reopen' ldisc comment
    Date
    This comment is a victim of code migration from
    "tty: Fix the ldisc hangup race"; re-parent it.

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/tty_ldisc.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
    index 7f7e1a3..0030d55 100644
    --- a/drivers/tty/tty_ldisc.c
    +++ b/drivers/tty/tty_ldisc.c
    @@ -854,11 +854,12 @@ void tty_ldisc_hangup(struct tty_struct *tty)
    */
    mutex_lock(&tty->ldisc_mutex);

    - /* At this point we have a closed ldisc and we want to
    - reopen it. We could defer this to the next open but
    - it means auditing a lot of other paths so this is
    - a FIXME */
    if (tty_ldisc_hangup_halt(tty)) {
    +
    + /* At this point we have a halted ldisc; we want to close it and
    + reopen a new ldisc. We could defer the reopen to the next
    + open but it means auditing a lot of other paths so this is
    + a FIXME */
    if (reset == 0) {

    if (!tty_ldisc_reinit(tty, tty->termios.c_line))
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-02-20 23:22    [W:4.032 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site