lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 02/23] n_tty: Factor packet mode status change for reuse
On 02/05/2013 09:20 PM, Peter Hurley wrote:
> Factor the packet mode status change from n_tty_flush_buffer
> for use by follow-on patch.
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> drivers/tty/n_tty.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index bf6958b..7194a33 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -237,6 +237,18 @@ static void reset_buffer_flags(struct tty_struct *tty)
> n_tty_set_room(tty);
> }
>
> +static void packet_mode_flush(struct tty_struct *tty)

I prefer naming functions according the name space they live in. In this
case n_tty_flush_packet_mode would be much better. Other than that this
one looks good.

--
js
suse labs


\
 
 \ /
  Last update: 2013-02-07 16:44    [W:0.438 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site