lkml.org 
[lkml]   [2012]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 00/11] tty: Fix buffer work access-after-free
From
Date
On Tue, 2012-12-18 at 10:44 -0500, Sasha Levin wrote:
> I'm still seeing that warning with the new patch series:
>
> [ 549.561769] ------------[ cut here ]------------
> [ 549.598755] WARNING: at drivers/tty/n_tty.c:160 n_tty_set_room+0xff/0x130()
> [ 549.604058] scheduling buffer work for halted ldisc
> [ 549.607741] Pid: 9417, comm: trinity-child28 Tainted: G D W
> 3.7.0-next-20121217-sasha-00023-g8689ef9 #219
> [ 549.652580] Call Trace:
> [ 549.662754] [<ffffffff81c432cf>] ? n_tty_set_room+0xff/0x130
> [ 549.665458] [<ffffffff8110cae7>] warn_slowpath_common+0x87/0xb0
> [ 549.668257] [<ffffffff8110cb71>] warn_slowpath_fmt+0x41/0x50
> [ 549.671007] [<ffffffff81c432cf>] n_tty_set_room+0xff/0x130
> [ 549.673268] [<ffffffff81c44597>] reset_buffer_flags+0x137/0x150
> [ 549.675607] [<ffffffff81c45b71>] n_tty_open+0x131/0x1c0

This is a false-positive warning that means I need to refine the warning
condition to not include this code path.

Thanks again.

> [ 549.677699] [<ffffffff81c47824>] tty_ldisc_open.isra.5+0x54/0x70
> [ 549.680147] [<ffffffff81c482bf>] tty_ldisc_hangup+0x11f/0x1e0
> [ 549.682409] [<ffffffff81c3fa17>] __tty_hangup+0x137/0x440
> [ 549.684634] [<ffffffff81c3fd49>] tty_vhangup+0x9/0x10
> [ 549.686443] [<ffffffff81c4a42c>] pty_close+0x14c/0x160
> [ 549.688446] [<ffffffff81c41225>] tty_release+0xd5/0x490
> [ 549.690460] [<ffffffff8127d8a2>] __fput+0x122/0x250
> [ 549.692577] [<ffffffff8127d9d9>] ____fput+0x9/0x10
> [ 549.694534] [<ffffffff811348c2>] task_work_run+0xb2/0xf0
> [ 549.696349] [<ffffffff81113c6d>] do_exit+0x36d/0x580
> [ 549.698286] [<ffffffff8107d964>] ? syscall_trace_enter+0x24/0x2e0
> [ 549.702729] [<ffffffff81113f4a>] do_group_exit+0x8a/0xc0
> [ 549.706775] [<ffffffff81113f92>] sys_exit_group+0x12/0x20
> [ 549.711088] [<ffffffff83cfab18>] tracesys+0xe1/0xe6
> [ 549.728001] ---[ end trace 73eb41728f11f87e ]---





\
 
 \ /
  Last update: 2012-12-18 18:21    [W:2.081 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site