Messages in this thread | | | Date | Thu, 07 Feb 2013 16:55:46 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH v3 01/23] tty: Add diagnostic for halted line discipline |
| |
On 02/07/2013 04:53 PM, Peter Hurley wrote: >>> +static int tty_ldisc_halt(struct tty_struct *tty) >>> +{ >>> + int scheduled; >>> + clear_bit(TTY_LDISC, &tty->flags); >>> + scheduled = cancel_work_sync(&tty->port->buf.work); >>> + set_bit(TTY_LDISC_HALTED, &tty->flags); >>> + return scheduled; >>> +} >> >> Why did you move with that function? It makes the patch unnecessarily >> bigger (and harder for a review). > > 07/23 starts using tty_wait_for_idle() in tty_ldisc_halt(). > > Should I split this?
Yes please.
-- js suse labs
| |