Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 17/21] perf tools: Factor out fill_callchain_info() | Date | Tue, 24 Dec 2013 17:22:23 +0900 |
| |
From: Namhyung Kim <namhyung.kim@lge.com>
The fill_callchain_info() will be shared with perf top --children.
Cc: Arun Sharma <asharma@fb.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/builtin-report.c | 39 ++------------------------------------- tools/perf/util/callchain.c | 42 ++++++++++++++++++++++++++++++++++++++++++ tools/perf/util/callchain.h | 2 ++ 3 files changed, 46 insertions(+), 37 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 1ec00acfcd92..a0d33ae3c1ef 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -417,44 +417,9 @@ iter_next_cumulative_entry(struct add_entry_iter *iter, if (node == NULL) return 0; - al->map = node->map; - al->sym = node->sym; - if (node->map) - al->addr = node->map->map_ip(node->map, node->ip); - else - al->addr = node->ip; - - if (al->sym == NULL) { - if (iter->rep->hide_unresolved) - return 0; - if (al->map == NULL) - goto out; - } - - if (al->map->groups == &iter->machine->kmaps) { - if (machine__is_host(iter->machine)) { - al->cpumode = PERF_RECORD_MISC_KERNEL; - al->level = 'k'; - } else { - al->cpumode = PERF_RECORD_MISC_GUEST_KERNEL; - al->level = 'g'; - } - } else { - if (machine__is_host(iter->machine)) { - al->cpumode = PERF_RECORD_MISC_USER; - al->level = '.'; - } else if (perf_guest) { - al->cpumode = PERF_RECORD_MISC_GUEST_USER; - al->level = 'u'; - } else { - al->cpumode = PERF_RECORD_MISC_HYPERVISOR; - al->level = 'H'; - } - } - -out: callchain_cursor_advance(&callchain_cursor); - return 1; + + return fill_callchain_info(al, node, iter->rep->hide_unresolved); } static int diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index c938da83144e..619cd0a0b284 100644 --- a/tools/perf/util/callchain.c +++ b/tools/perf/util/callchain.c @@ -554,3 +554,45 @@ int hist_entry__append_callchain(struct hist_entry *he, struct perf_sample *samp return 0; return callchain_append(he->callchain, &callchain_cursor, sample->period); } + +int fill_callchain_info(struct addr_location *al, struct callchain_cursor_node *node, + bool hide_unresolved) +{ + al->map = node->map; + al->sym = node->sym; + if (node->map) + al->addr = node->map->map_ip(node->map, node->ip); + else + al->addr = node->ip; + + if (al->sym == NULL) { + if (hide_unresolved) + return 0; + if (al->map == NULL) + goto out; + } + + if (al->map->groups == &al->machine->kmaps) { + if (machine__is_host(al->machine)) { + al->cpumode = PERF_RECORD_MISC_KERNEL; + al->level = 'k'; + } else { + al->cpumode = PERF_RECORD_MISC_GUEST_KERNEL; + al->level = 'g'; + } + } else { + if (machine__is_host(al->machine)) { + al->cpumode = PERF_RECORD_MISC_USER; + al->level = '.'; + } else if (perf_guest) { + al->cpumode = PERF_RECORD_MISC_GUEST_USER; + al->level = 'u'; + } else { + al->cpumode = PERF_RECORD_MISC_HYPERVISOR; + al->level = 'H'; + } + } + +out: + return 1; +} diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h index 8ad97e9b119f..66faae21370d 100644 --- a/tools/perf/util/callchain.h +++ b/tools/perf/util/callchain.h @@ -155,6 +155,8 @@ int sample__resolve_callchain(struct perf_sample *sample, struct symbol **parent struct perf_evsel *evsel, struct addr_location *al, int max_stack); int hist_entry__append_callchain(struct hist_entry *he, struct perf_sample *sample); +int fill_callchain_info(struct addr_location *al, struct callchain_cursor_node *node, + bool hide_unresolved); extern const char record_callchain_help[]; #endif /* __PERF_CALLCHAIN_H */ -- 1.7.11.7
| |