lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 18/21] perf top: Support callchain accumulation
    Date
    On Sun, 5 Jan 2014 19:01:54 +0100, Jiri Olsa wrote:
    > On Tue, Dec 24, 2013 at 05:22:24PM +0900, Namhyung Kim wrote:
    >> From: Namhyung Kim <namhyung.kim@lge.com>
    >>
    >> Enable cumulation of callchain of children in perf top.
    >>
    >> Cc: Arun Sharma <asharma@fb.com>
    >> Cc: Frederic Weisbecker <fweisbec@gmail.com>
    >> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    >> ---
    >> tools/perf/builtin-top.c | 106 +++++++++++++++++++++++++++++++++++++++++++++--
    >> 1 file changed, 103 insertions(+), 3 deletions(-)
    >>
    >> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    >> index 48c527a0f4c8..6a7a76496c94 100644
    >> --- a/tools/perf/builtin-top.c
    >> +++ b/tools/perf/builtin-top.c
    >> @@ -657,6 +657,99 @@ static int symbol_filter(struct map *map __maybe_unused, struct symbol *sym)
    >> return 0;
    >> }
    >>
    >> +static int process_cumulative_entry(struct perf_top *top,
    >> + struct hist_entry *he,
    >> + struct perf_evsel *evsel,
    >> + struct addr_location *al,
    >> + struct perf_sample *sample,
    >> + struct symbol *parent)
    >> +{
    >
    > hum, I wonder how hard would it be to export the iterator
    > stuff out of the report command and export it to be usable
    > from here as well.. to much code dusplicated below :-\

    Yeah, I should find a way to reuse the code.

    Thanks,
    Namhyung


    \
     
     \ /
      Last update: 2014-01-06 10:01    [W:3.847 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site