lkml.org 
[lkml]   [2014]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/21] perf tools: Enable --children option by default
On Tue, Dec 24, 2013 at 05:22:27PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> Now perf top and perf report will show children column by default if
> it has callchain information.
>
> Requested-by: Ingo Molnar <mingo@kernel.org>

hum, so I could easily put 'children = false' to my .perfconfig
to get the previous default behaviour back..

but I thought the notion was not to disturb user with
new features ...and I feel disturbed ;-)

I probably missed some discussion about this

jirka

> Cc: Arun Sharma <asharma@fb.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/symbol.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 923d00040bbf..3e73079e6c92 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -29,11 +29,12 @@ int vmlinux_path__nr_entries;
> char **vmlinux_path;
>
> struct symbol_conf symbol_conf = {
> - .use_modules = true,
> - .try_vmlinux_path = true,
> - .annotate_src = true,
> - .demangle = true,
> - .symfs = "",
> + .use_modules = true,
> + .try_vmlinux_path = true,
> + .annotate_src = true,
> + .demangle = true,
> + .cumulate_callchain = true,
> + .symfs = "",
> };
>
> static enum dso_binary_type binary_type_symtab[] = {
> --
> 1.7.11.7
>


\
 
 \ /
  Last update: 2014-01-05 19:21    [W:0.472 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site