lkml.org 
[lkml]   [2014]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/21] perf ui/browser: Add support to accumulated hist stat
    On Tue, Dec 24, 2013 at 05:22:16PM +0900, Namhyung Kim wrote:
    > From: Namhyung Kim <namhyung.kim@lge.com>
    >
    > Print accumulated stat of a hist entry if requested.
    >
    > Cc: Arun Sharma <asharma@fb.com>
    > Cc: Frederic Weisbecker <fweisbec@gmail.com>
    > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    > ---
    > tools/perf/ui/browsers/hists.c | 17 +++++++++++++++++
    > 1 file changed, 17 insertions(+)
    >
    > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
    > index a440e03cd8c2..efa78894f70d 100644
    > --- a/tools/perf/ui/browsers/hists.c
    > +++ b/tools/perf/ui/browsers/hists.c
    > @@ -693,11 +693,26 @@ hist_browser__hpp_color_##_type(struct perf_hpp_fmt *fmt __maybe_unused,\
    > return __hpp__color_fmt(hpp, he, __hpp_get_##_field, _cb); \
    > }
    >
    > +#define __HPP_COLOR_ACC_PERCENT_FN(_type, _field, _cb) \
    > +static u64 __hpp_get_acc_##_field(struct hist_entry *he) \
    > +{ \
    > + return he->stat_acc->_field; \
    > +} \
    > + \
    > +static int \
    > +hist_browser__hpp_color_##_type(struct perf_hpp_fmt *fmt __maybe_unused,\
    > + struct perf_hpp *hpp, \
    > + struct hist_entry *he) \
    > +{ \
    > + return __hpp__color_fmt(hpp, he, __hpp_get_acc_##_field, _cb); \
    > +}
    > +
    > __HPP_COLOR_PERCENT_FN(overhead, period, __hpp__color_callchain)
    > __HPP_COLOR_PERCENT_FN(overhead_sys, period_sys, NULL)
    > __HPP_COLOR_PERCENT_FN(overhead_us, period_us, NULL)
    > __HPP_COLOR_PERCENT_FN(overhead_guest_sys, period_guest_sys, NULL)
    > __HPP_COLOR_PERCENT_FN(overhead_guest_us, period_guest_us, NULL)
    > +__HPP_COLOR_ACC_PERCENT_FN(overhead_acc, period, NULL)

    same comment as for ui/hist.c..

    including _type parameter in __HPP_COLOR_PERCENT_FN ;-)

    jirka


    \
     
     \ /
      Last update: 2014-01-05 19:21    [W:4.253 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site