lkml.org 
[lkml]   [2014]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/21] perf tools: Introduce struct add_entry_iter
On Tue, Dec 24, 2013 at 05:22:07PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>

SNIP

> +
> +out:
> + iter->curr++;
> + return err;
> +}
> +
> +static int
> +iter_finish_branch_entry(struct add_entry_iter *iter,
> + struct addr_location *al __maybe_unused)
> +{
> + free(iter->priv);
> + iter->priv = NULL;

so branch_info is duplicated in the hist_entry__new.. it's not
easy to find why this one gets freed while mem_info stays ;-)

some comment about that here would help

jirka


\
 
 \ /
  Last update: 2014-01-05 17:01    [W:0.201 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site