lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 21/33] pinctrl: Convert to devm_ioremap_resource()
From
On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
> index 3cf4ecd..295b349 100644
> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
> @@ -540,11 +540,9 @@ static int plgpio_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> - plgpio->base = devm_request_and_ioremap(&pdev->dev, res);
> - if (!plgpio->base) {
> - dev_err(&pdev->dev, "request and ioremap fail\n");

can we keep this as is?

> - return -ENOMEM;
> - }
> + plgpio->base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(plgpio->base))
> + return PTR_ERR(plgpio->base);
>

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


\
 
 \ /
  Last update: 2013-01-21 12:42    [W:1.260 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site