lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 12/33] Input: Convert to devm_ioremap_resource()
    From
    On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
    <thierry.reding@avionic-design.de> wrote:
    > diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
    > @@ -228,11 +228,9 @@ static int spear_kbd_probe(struct platform_device *pdev)
    > kbd->suspended_rate = pdata->suspended_rate;
    > }
    >
    > - kbd->io_base = devm_request_and_ioremap(&pdev->dev, res);
    > - if (!kbd->io_base) {
    > - dev_err(&pdev->dev, "request-ioremap failed for kbd_region\n");

    I would like to keep this error message as is.

    > - return -ENOMEM;
    > - }
    > + kbd->io_base = devm_ioremap_resource(&pdev->dev, res);
    > + if (IS_ERR(kbd->io_base))
    > + return PTR_ERR(kbd->io_base);

    apart from that, for SPEAr

    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


    \
     
     \ /
      Last update: 2013-01-21 12:21    [W:4.152 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site