| Date | Mon, 21 Jan 2013 16:20:28 +0530 | Subject | Re: [PATCH 24/33] rtc: Convert to devm_ioremap_resource() | From | Viresh Kumar <> |
| |
On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding <thierry.reding@avionic-design.de> wrote: > diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c > index c2121b5..a18c319 100644 > --- a/drivers/rtc/rtc-spear.c > +++ b/drivers/rtc/rtc-spear.c > @@ -385,11 +385,9 @@ static int spear_rtc_probe(struct platform_device *pdev) > return status; > } > > - config->ioaddr = devm_request_and_ioremap(&pdev->dev, res); > - if (!config->ioaddr) { > - dev_err(&pdev->dev, "request-ioremap fail\n");
can we keep it as is?
> - return -ENOMEM; > - } > + config->ioaddr = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(config->ioaddr)) > + return PTR_ERR(config->ioaddr); >
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
|