lkml.org 
[lkml]   [2013]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 28/33] serial: Convert to devm_ioremap_resource()
    Date
    Convert all uses of devm_request_and_ioremap() to the newly introduced
    devm_ioremap_resource() which provides more consistent error handling.

    devm_ioremap_resource() provides its own error messages so all explicit
    error messages can be removed from the failure code paths.

    Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Alan Cox <alan@linux.intel.com>
    Cc: linux-serial@vger.kernel.org
    ---
    drivers/tty/serial/sccnxp.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c
    index 418b495..e869eab 100644
    --- a/drivers/tty/serial/sccnxp.c
    +++ b/drivers/tty/serial/sccnxp.c
    @@ -15,6 +15,7 @@
    #define SUPPORT_SYSRQ
    #endif

    +#include <linux/err.h>
    #include <linux/module.h>
    #include <linux/device.h>
    #include <linux/console.h>
    @@ -875,10 +876,9 @@ static int sccnxp_probe(struct platform_device *pdev)
    goto err_out;
    }

    - membase = devm_request_and_ioremap(&pdev->dev, res);
    - if (!membase) {
    - dev_err(&pdev->dev, "Failed to ioremap\n");
    - ret = -EIO;
    + membase = devm_ioremap_resource(&pdev->dev, res);
    + if (IS_ERR(membase)) {
    + ret = PTR_ERR(membase);
    goto err_out;
    }

    --
    1.8.1.1


    \
     
     \ /
      Last update: 2013-01-22 09:46    [W:4.276 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site