| Date | Sun, 30 Sep 2012 18:11:01 -0500 | From | Daniel Santos <> | Subject | Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro |
| |
So in light of feedback I've been getting on this patch set, it leaves me with this question. > +#define GCC_VERSION (__GNUC__ * 10000 \ > + + __GNUC_MINOR__ * 100 \ > + + __GNUC_PATCHLEVEL__) This macro presumes you are using gcc 3.0 or later, which introduced the __GNUC_PATCHLEVEL__ predefined macro. Should you be using a version of gcc prior to 3.0 (where the macro is undefined), you would get an error that __GNUC_PATCHLEVEL__ is undefined prior to getting the error trying to include "linux/compiler-gcc2.h". So it presumes the compiler is 3.0+, when another part of the code may allow it from a future change. Should it be modified to do account for this or would that be overkill?
#ifdef __GNUC_PATCHLEVEL__ # define GCC_VERSION (__GNUC__ * 10000 \ + __GNUC_MINOR__ * 100 \ + __GNUC_PATCHLEVEL__) #else # define GCC_VERSION (__GNUC__ * 10000 \ + __GNUC_MINOR__ * 100) #endif
Daniel
|