lkml.org 
[lkml]   [2012]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro
    On Fri, 28 Sep 2012, Josh Triplett wrote:

    > GCC 4.1.0 and 4.1.1 miscompiling __weak has nothing to do with
    > __compiletime_object_size; why should *this* version check exclude those
    > versions?
    >

    Agreed, we shouldn't be relying on any #error directives to fail the build
    and then try to factor those version numbers out of other directives; if
    the #error directive were ever to be removed (or commented out, like in
    this case), nobody would make the other directives inclusive of that
    now-allowed version where things like __compiletime_object_size() are
    valid.

    After __compiletime_object_size() is compiled for GCC_VERSION >= 40100,
    then:

    Acked-by: David Rientjes <rientjes@google.com>


    \
     
     \ /
      Last update: 2012-10-03 09:21    [W:2.242 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site