Messages in this thread | | | Date | Wed, 24 Oct 2012 21:55:20 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 04/10] bug.h: directly include linux/compiler.h |
| |
On Wed, Oct 24, 2012 at 11:33:55AM -0500, danielfsantos@att.net wrote: > Currently, we are only including asm/bug.h and then expecting that > linux/compiler.h will eventually be included to define __linktime_error > (used in BUILD_BUG_ON). This patch includes it directly for clarity and > to avoid the possibility of changes in <arch>/*/include/asm/bug.h being > changed or not including linux/compiler.h for some reason. (Later > patches will in this set use more macros defined in compiler*.h.) > > Signed-off-by: Daniel Santos <daniel.santos@pobox.com> > --- > include/linux/bug.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/bug.h b/include/linux/bug.h > index aaac4bb..4bd74d8 100644 > --- a/include/linux/bug.h > +++ b/include/linux/bug.h > @@ -2,6 +2,7 @@ > #define _LINUX_BUG_H > > #include <asm/bug.h> > +#include <linux/compiler.h> > > enum bug_trap_type { > BUG_TRAP_TYPE_NONE = 0, > -- > 1.7.3.4
Why is this a separate patch and why not add that single line in 6/10 where you define BUILD_BUG_ON?
Thanks.
-- Regards/Gruss, Boris.
| |