Messages in this thread | | | Subject | Re: Announce: Semaphore-Removal tree | From | Daniel Walker <> | Date | Fri, 25 Apr 2008 13:38:37 -0700 |
| |
On Fri, 2008-04-25 at 11:00 -0600, Matthew Wilcox wrote: > http://git.kernel.org/?p=linux/kernel/git/willy/misc.git;a=shortlog;h=semaphore-removal >
I was reviewing your patches, and I don't like the semaphore to spinlock changes.. There's no reason to start adding spinlocks, unless it's really performance sensitive which none of those places are..
Also the ps3-gelic changes for instance is three locks in one patch. It should be one lock per patch .. I have a broken out conversion for gelic which I was going to submit in my next round ..
There's also a number of other people doing these , so you might want to hold off on doing more unless you know they aren't already completed ..
Daniel
| |